Ping multisig #137
Merged
Ping multisig #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
reviewed
Oct 4, 2024
MatusKysel
reviewed
Oct 4, 2024
Comment on lines
+116
to
+117
| Multisig bool | ||
| EthClientConnected bool |
There was a problem hiding this comment.
do we need both? isn't it enough just multisig? it won't be working without eth, right ?
There was a problem hiding this comment.
we check connection to eth client when start operator, if no it cant start, but we can loose it after we started. So we can be Multisig=true and EthClientConnected=false.
For old operator versions we dont have both fields so it will be false, false.
If we have only EthClientConnected then we cant distinguish between old and new version, only comparing version. So Multisig is rather informational for users not to compare versions, as old will be always false
Please let me know if it makes sense.
MatusKysel
reviewed
Oct 4, 2024
| for _, s := range servers { | ||
| ips = append(ips, s.HttpSrv.URL) | ||
| } | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
what err are you checking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
pongto include fieldsMultisig,EthClientConnected