Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --multisig Flag to Ping Command to Verify Multisig Support #128

Closed
MatusKysel opened this issue Sep 26, 2024 · 1 comment · Fixed by #137
Closed

Add --multisig Flag to Ping Command to Verify Multisig Support #128

MatusKysel opened this issue Sep 26, 2024 · 1 comment · Fixed by #137

Comments

@MatusKysel
Copy link
Contributor

Background

Some operators may be misconfigured or not connected to Ethereum 1.0 (eth1), which is necessary for multisig functionality. We need a way to identify operators that support multisig.

Task

  • Enhance Ping Command:

    • Add a --multisig flag to the ping command.
    • When this flag is used, the ping command should fail if the operator is not connected to eth1.
  • Update Health Check:

    • Modify the health check to verify multisig support on all operators.

Acceptance Criteria

  • The ping command with --multisig:

    • Succeeds only if the operator is connected to eth1.
    • Fails with a clear error message if not connected.
  • Health check reports accurately reflect multisig support status.

  • Documentation is updated to include the new --multisig flag.


By implementing this, we can ensure that we only use operators that support multisig and are properly connected to eth1.

@pavelkrolevets
Copy link
Contributor

pavelkrolevets commented Oct 3, 2024

IMO we dont even need a flag to ping. We just GET new pong message with fields indicating that its multisig + connected or nothing. In this case if we ping old operators we got a message that they online but multisig not supported.

Here is the implementation #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants