Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ipv6 for kubernetes #1071

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: support ipv6 for kubernetes #1071

merged 1 commit into from
Sep 19, 2024

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Sep 5, 2024 •
edited
Loading

Description

Adds to SC4SNMP support for polling and receiving traps notifications from IPv6 devices.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature

How Has This Been Tested?

unit, integration and manual tests

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ajasnosz ajasnosz force-pushed the feat/support-ipv6 branch 3 times, most recently from e179bff to 076adb0 Compare September 9, 2024 11:14
@ajasnosz ajasnosz marked this pull request as ready for review September 9, 2024 11:14
ikheifets-splunk
ikheifets-splunk reviewed Sep 18, 2024
View reviewed changes
Copy link

@ikheifets-splunk ikheifets-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I understood correctly that's only k8s? Or for docker it's working out of the box

@ajasnosz ajasnosz changed the title feat: support ipv6 feat: support ipv6 for kubernetes Sep 18, 2024
@ajasnosz
Copy link
Collaborator Author

am I understood correctly that's only k8s? Or for docker it's working out of the box

I've changed the pr name to match what it is. That part is only for k8s, for docker it will be done in different pr

@ajasnosz ajasnosz merged commit 53a586f into develop Sep 19, 2024
11 of 12 checks passed
@ajasnosz ajasnosz deleted the feat/support-ipv6 branch September 19, 2024 07:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.12.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikheifets-splunk ikheifets-splunk ikheifets-splunk approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajasnosz @srv-rr-github-token @ikheifets-splunk