feat: change chart value [run-int-tests]

splunk · Sep 18, 2024 · 9bc9e8a · 9bc9e8a
1 parent 221cc42
commit 9bc9e8a
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 8 deletions.
diff --git a/charts/splunk-connect-for-snmp/templates/traps/deployment.yaml b/charts/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -85,7 +85,11 @@ spec:
                     name: {{ include "splunk-connect-for-snmp.name" . }}-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: {{ .Values.traps.ipFamilies | quote }}
+              {{- if has "IPv6" .Values.traps.ipFamilies}}
+              value: "true"
+              {{ else }}
+              value: "false"
+              {{- end }}
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/rendered/manifests/tests/splunk-connect-for-snmp/templates/traps/deployment.yaml b/rendered/manifests/tests/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -56,6 +56,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -72,7 +74,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/...nifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/traps/deployment.yaml b/...nifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -55,6 +55,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -71,7 +73,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/...ts_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/traps/deployment.yaml b/...ts_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -55,6 +55,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -71,7 +73,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/traps/deployment.yaml b/rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -56,6 +56,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -72,7 +74,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/traps/deployment.yaml b/rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -56,6 +56,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -72,7 +74,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/...ed/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/traps/deployment.yaml b/...ed/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/traps/deployment.yaml
@@ -56,6 +56,8 @@ spec:
               value: "http://release-name-mibserver/standard.txt"
             - name: LOG_LEVEL
               value: INFO
+            - name: PYSNMP_DEBUG
+              value: ""
             - name: SPLUNK_HEC_SCHEME
               value: "https"
             - name: SPLUNK_HEC_HOST
@@ -72,7 +74,7 @@ spec:
                     name: splunk-connect-for-snmp-splunk
                     key: hec_token
             - name: IPv6_ENABLED
-              value: "[IPv4]"
+              value: "false"
           ports:
             - name: snmp-udp
               containerPort: 2162

diff --git a/splunk_connect_for_snmp/traps.py b/splunk_connect_for_snmp/traps.py
@@ -18,6 +18,7 @@
 
 from pysnmp.proto.api import v2c
 
+from splunk_connect_for_snmp.common.hummanbool import human_bool
 from splunk_connect_for_snmp.snmp.auth import get_secret_value
 
 with suppress(ImportError, OSError):
@@ -49,7 +50,7 @@
 SECURITY_ENGINE_ID_LIST = os.getenv("SNMP_V3_SECURITY_ENGINE_ID", "80003a8c04").split(
     ","
 )
-IPv6_ENABLED = True if "ipv6" in os.getenv("IPv6_ENABLED", "[IPv4]").lower() else False
+IPv6_ENABLED = human_bool(os.getenv("IPv6_ENABLED", "false").lower())
 LOG_LEVEL = os.getenv("LOG_LEVEL", "INFO")
 PYSNMP_DEBUG = os.getenv("PYSNMP_DEBUG", "")