Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NTP #14

Merged
merged 6 commits into from
Jan 1, 2024

correct ntp header; add more Timestamp tests

01ef9ac
Select commit
Loading
Failed to load commit list.
Merged

Implement NTP #14

correct ntp header; add more Timestamp tests
01ef9ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 1, 2024 in 0s

44.26% (-1.67%) compared to 289e517

View this Pull Request on Codecov

44.26% (-1.67%) compared to 289e517

Details

Codecov Report

Attention: 194 lines in your changes are missing coverage. Please review.

Comparison is base (289e517) 45.92% compared to head (01ef9ac) 44.26%.

Files Patch % Lines
stacks/ntp_client.go 0.00% 104 Missing ⚠️
eth/ntp/ntp.go 26.72% 82 Missing and 3 partials ⚠️
stacks/portstack.go 50.00% 2 Missing and 1 partial ⚠️
valuesize.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   45.92%   44.26%   -1.67%     
==========================================
  Files          22       24       +2     
  Lines        3874     4103     +229     
==========================================
+ Hits         1779     1816      +37     
- Misses       1873     2061     +188     
- Partials      222      226       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.