Implement NTP #14
Merged
Implement NTP #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 45.92% 44.26% -1.67%
==========================================
Files 22 24 +2
Lines 3874 4103 +229
==========================================
+ Hits 1779 1816 +37
- Misses 1873 2061 +188
- Partials 222 226 +4 ☔ View full report in Codecov by Sentry. |
soypat
added a commit
that referenced
this pull request
Jan 2, 2024
* add dns package * redo api's and add append methods * fix DNS message encode/decode test * dns: add incomplete parsing feature * prepare for ntp merge * Implement NTP (#14) * add ntp package * finished NTP in the nick of time * better NTP control flow * more fixes to NTP API * add ntp.Header.SetFlags * correct ntp header; add more Timestamp tests * flesh out dns logic * flesh out more of DNS logic * huge improvements to DHCP inspired by DNS client * rename dhcpclient's Done->IsDone
soypat
added a commit
that referenced
this pull request
Apr 6, 2024
* add dns package * redo api's and add append methods * fix DNS message encode/decode test * dns: add incomplete parsing feature * prepare for ntp merge * Implement NTP (#14) * add ntp package * finished NTP in the nick of time * better NTP control flow * more fixes to NTP API * add ntp.Header.SetFlags * correct ntp header; add more Timestamp tests * flesh out dns logic * flesh out more of DNS logic * huge improvements to DHCP inspired by DNS client * rename dhcpclient's Done->IsDone
soypat
added a commit
that referenced
this pull request
Apr 6, 2024
* add ntp package * finished NTP in the nick of time * better NTP control flow * more fixes to NTP API * add ntp.Header.SetFlags * correct ntp header; add more Timestamp tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP. Not sure what else is needed- maybe DNS to discover NTP services such as
ntp://pool.ntp.org?