-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stable contract offer id #795
Merged
richardtreier
merged 8 commits into
main
from
278-2027-02-13-unstable-contract-offer-id
Feb 16, 2024
Merged
Add stable contract offer id #795
richardtreier
merged 8 commits into
main
from
278-2027-02-13-unstable-contract-offer-id
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ununhexium
force-pushed
the
278-2027-02-13-unstable-contract-offer-id
branch
2 times, most recently
from
February 13, 2024 10:58
3ef07d0
to
61a998a
Compare
ununhexium
force-pushed
the
278-2027-02-13-unstable-contract-offer-id
branch
from
February 13, 2024 11:10
61a998a
to
05bbf65
Compare
ununhexium
requested review from
jridderbusch and
richardtreier
and removed request for
jridderbusch
February 13, 2024 11:17
richardtreier
requested changes
Feb 13, 2024
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
richardtreier
requested changes
Feb 13, 2024
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
utils/catalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspDataOfferBuilder.java
Outdated
Show resolved
Hide resolved
richardtreier
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
richardtreier
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dhommen
pushed a commit
to truzzt/edc-extensions
that referenced
this pull request
Mar 25, 2024
dhommen
pushed a commit
to truzzt/edc-extensions
that referenced
this pull request
Mar 26, 2024
dhommen
pushed a commit
to truzzt/edc-extensions
that referenced
this pull request
Mar 27, 2024
dhommen
pushed a commit
to truzzt/edc-extensions
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
(Note: this is in an issue in a different repo)
Checklist