feat: stable contract offer id in DspCatalogService (sovity#795)

truzzt · Mar 26, 2024 · 0be4127 · 0be4127
1 parent d5c5a84
commit 0be4127
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
 - API Wrapper: TS Client Library now supports OAuth Client Credentials
 
 #### Patch Changes
+- DspCatalogService: Contract Offer IDs are now stable
 
 - Add e2e test for double encoding of query parameters
 

diff --git a/...atalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspContractOfferUtils.java b/...atalog-parser/src/main/java/de/sovity/edc/utils/catalog/mapper/DspContractOfferUtils.java
@@ -29,7 +29,7 @@ public class DspContractOfferUtils {
      * @return A base64 string that can be used as an id for the {@code contract}
      */
     public static String buildStableId(JsonObject contract) {
-        // NOTE: This doesn't enforce any property order and may cause trouble if the returned policy schema is not consistent.
+        // FIXME: This doesn't enforce any property order and may cause trouble if the returned policy schema is not consistent.
         //  Use canonical form if needed later.
         val noId = Json.createObjectBuilder(contract).remove(Prop.ID).build();
         val policyId = hash(noId);