Fix VSCode build #48559
Fix VSCode build #48559
Conversation
There were two issues: - One was resolved by following the steps in microsoft/PowerBI-visuals-tools#365 (comment) - The other one was caused by the .ttf icon in monaco being moved, I changed the rule to now bundle any ttf with the full name (we only have one anyways).
github-actions
bot
added
the
team/code-exploration
client/vscode/webpack.config.js
Outdated
| // Monaco Editor Path | ||
| const MONACO_EDITOR_PATH = path.resolve(rootPath, 'node_modules', 'monaco-editor') | ||
| // Codicons Path | ||
| const CODICONS_PATH = path.resolve(rootPath, 'node_modules', '@vscode', 'codicons') |
There was a problem hiding this comment.
Yeah we inject it manually. Not sure why but it's definitely loaded by the extension :/
There was a problem hiding this comment.
@fkling There's no chance that VSCode still uses the old search input right? right?? that one's gone?? so we should be able to rm? :D
There was a problem hiding this comment.
There was a problem hiding this comment.
I mean the variable seems to have been added but not references in the webpack config file... or am I missing anything?
I removed the Monaco query input implementation so... I guess vscode can't use it anymore 😄
There was a problem hiding this comment.
Oh sorry, I was confused. You're right this line can be delted I've made it work for all .ttf files now.
@fkling oof lots of cleanup potential for VSCode then. But no time 😢
There were two issues:
Test plan
Always happy to see @muratsu's face again 🙂
App preview:
Check out the client app preview documentation to learn more.