This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Run VSCode build on main CI again #48560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
requested review from
valerybugakov,
taras-yemets,
abeatrix and
a team
github-actions
bot
added
the
team/code-exploration
taras-yemets
approved these changes
Mar 2, 2023
|
The build will probably break until we land https://github.com/sourcegraph/sourcegraph/pull/48559 |
|
GOOD (rebasing onto
|
This brings back some stuff from the VS Code pipeline into `main`. We're now at least building the VSCode extension when `client/` files change. This is necessary because we were breaking the build setup too often which took a while to fix and made it harder for us to push fixes. The E2E tests are still disabled until we investigate into the flakiness.
philipp-spiess
force-pushed
the
ps/vscode-build-on-ci
branch
from
a202191
to
f65cf9d
Compare
abeatrix
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back some stuff from the VS Code pipeline into
main.We're now at least building the VSCode extension when
client/files change. This is necessary because we were breaking the build setup too often which took a while to fix and made it harder for us to push fixes.The E2E tests are still disabled until we investigate into the flakiness.
Test plan