Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package edition field #858

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add package edition field #858

merged 2 commits into from
Nov 6, 2023

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Nov 5, 2023

No description provided.

@maciektr maciektr requested a review from mkaput as a code owner November 5, 2023 11:58
mkaput
mkaput requested changes Nov 6, 2023
View reviewed changes
scarb-metadata/src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
scarb/src/ops/metadata.rs Outdated Show resolved Hide resolved
scarb/tests/metadata.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/src/compiler/db.rs Outdated Show resolved Hide resolved
scarb/src/compiler/db.rs Show resolved Hide resolved
@maciektr maciektr force-pushed the maciektr/editions branch 2 times, most recently from daa9df7 to c5a7ad7 Compare November 6, 2023 16:31
@maciektr maciektr requested a review from mkaput November 6, 2023 16:32
mkaput
mkaput approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maciektr maciektr added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 333dd13 Nov 6, 2023
11 checks passed
@maciektr maciektr deleted the maciektr/editions branch November 6, 2023 20:58
tomek0123456789 pushed a commit that referenced this pull request Nov 8, 2023
@maciektr @tomek0123456789
Add package edition field (#858)
e53c9bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @mkaput