Add edition field to PackageMetadata

software-mansion · Nov 6, 2023 · c5a7ad7 · c5a7ad7
1 parent 28d74ca
commit c5a7ad7
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 1 deletion.
diff --git a/scarb-metadata/src/lib.rs b/scarb-metadata/src/lib.rs
@@ -208,6 +208,10 @@ pub struct PackageMetadata {
     /// Package version as given in `Scarb.toml`.
     pub version: Version,
 
+    /// Package edition as given in `Scarb.toml`.
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub edition: Option<String>,
+
     /// The source of the package.
     pub source: SourceId,
 

diff --git a/scarb/Cargo.toml b/scarb/Cargo.toml
@@ -55,8 +55,8 @@ serde-untagged.workspace = true
 serde-value.workspace = true
 serde.workspace = true
 serde_json.workspace = true
-sha2.workspace = true
 serde_repr.workspace = true
+sha2.workspace = true
 smallvec.workspace = true
 smol_str.workspace = true
 tar.workspace = true

diff --git a/scarb/src/ops/metadata.rs b/scarb/src/ops/metadata.rs
@@ -125,10 +125,13 @@ fn collect_package_metadata(package: &Package) -> m::PackageMetadata {
         .build()
         .unwrap();
 
+    let edition = serde_json::to_value(package.manifest.edition).unwrap();
+
     m::PackageMetadataBuilder::default()
         .id(wrap_package_id(package.id))
         .name(package.id.name.clone())
         .version(package.id.version.clone())
+        .edition(Some(edition.to_string()))
         .source(wrap_source_id(package.id.source_id))
         .manifest_path(package.manifest_path())
         .root(package.root())

diff --git a/scarb/tests/metadata.rs b/scarb/tests/metadata.rs
@@ -1112,3 +1112,29 @@ fn infer_readme_workspace() {
     assert_eq!(packages.get("t5").unwrap().manifest_metadata.readme, None);
     assert_eq!(packages.get("t6").unwrap().manifest_metadata.readme, None);
 }
+
+#[test]
+fn includes_edition() {
+    let t = assert_fs::TempDir::new().unwrap();
+    ProjectBuilder::start()
+        .name("hello")
+        .version("0.1.0")
+        .edition("2023_10")
+        .build(&t);
+
+    let metadata = Scarb::quick_snapbox()
+        .arg("--json")
+        .arg("metadata")
+        .arg("--format-version")
+        .arg("1")
+        .current_dir(&t)
+        .stdout_json::<Metadata>();
+
+    for package in metadata.packages {
+        if package.name == "hello" {
+            assert_eq!(package.edition, Some("2023_10".to_string()));
+            return;
+        }
+    }
+    panic!("Package not found in metadata!");
+}