Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discoverRootDomain default behaviour #1350

Merged
merged 1 commit into from
Oct 8, 2024

Commits on Oct 4, 2024

  1. Update discoverRootDomain default behaviour

    In v3, `discoverRootDomain` was disabled by default, and enabling it
    meant ignoring the `cookieDomain` configuration. If neither were set,
    cookies would have no `Domain` attribute attached and would bind to the
    current domain; cookies with no domain are unique in that they do not
    get shared to subdomains.
    
    In 257ddb3 we updated
    the `discoverRootDomain` setting to default to enabled, and changed how it
    interacted with the `cookieDomain` setting so that `discoverRootDomain`
    is essentially always enabled, but gets ignored if `cookieDomain` is
    also specified. This however made it impossible to use the 'no domain'
    behaviour available in v3, because disabling `discoverRootDomain` would
    have no effect without specifying `cookieDomain` as well.
    
    This can be slightly confusing, so instead, this change allows
    explicitly disabling `discoverRootDomain` even if no `cookieDomain` is
    specified, allowing the same behaviour as all configurations available
    in v3.
    jethron committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    70f7393 View commit details
    Browse the repository at this point in the history