Update discoverRootDomain default behaviour #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3,
discoverRootDomain
was disabled by default, and enabling it meant ignoring thecookieDomain
configuration. If neither were set, cookies would have noDomain
attribute attached and would bind to the current domain; cookies with no domain are unique in that they do not get shared to subdomains.In 257ddb3 we updated the
discoverRootDomain
setting to default to enabled, and changed how it interacted with thecookieDomain
setting so thatdiscoverRootDomain
is essentially always enabled, but gets ignored ifcookieDomain
is also specified. This however made it impossible to use the 'no domain' behaviour available in v3, because disablingdiscoverRootDomain
would have no effect without specifyingcookieDomain
as well.This can be slightly confusing, so instead, this change allows explicitly disabling
discoverRootDomain
even if nocookieDomain
is specified, allowing the same behaviour as all configurations available in v3.