Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(404): redirect to dashboard page #4100

Merged
merged 15 commits into from
Aug 3, 2023

Conversation

Todmy
Copy link
Contributor

@Todmy Todmy commented Jul 28, 2023

Issues

#102

Fixes #
add redirect to /

Changes

add vercel.json config file

How to test

  1. Open some not existing pages, e.g. https://snapshot.org/sialala (use your own domain)
  2. Vercel shouldn't show 404 and just show a dashboard (unfortunately the link will be https://snapshot.org/sialala/#/

To-Do

  • [ ]

Self-review checklist

  • I have performed a full self-review of my changes
  • I have tested my changes on a preview deployment
  • I have tested my changes on different screen sizes (sm, md)
  • I have tested my changes on a custom domain

Additional notes or considerations

(Include any other relevant information or context that may be helpful for the reviewer)

@Todmy Todmy self-assigned this Jul 28, 2023
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 11:21am

@vercel
Copy link

vercel bot commented Jul 28, 2023

Deployment failed with the following error:

Rewrite at index 0 has invalid `source` pattern "/*".

Learn More: https://vercel.link/invalid-route-source-pattern

@vercel
Copy link

vercel bot commented Jul 28, 2023

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: `rewrites[0]` should NOT have additional property `permanent`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

@Todmy Todmy mentioned this pull request Jul 28, 2023
@Todmy Todmy requested a review from samuveth July 28, 2023 11:28
Copy link
Contributor

@samuveth samuveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@samuveth samuveth merged commit 8dbfa4e into develop Aug 3, 2023
6 of 7 checks passed
@samuveth samuveth deleted the todmy/fix-vercel-default-redirect branch August 3, 2023 23:38
@samuveth
Copy link
Contributor

samuveth commented Aug 3, 2023

@Todmy nice one I needed this for Tune histoire too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants