Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 page #102

Closed
gokaiorg opened this issue Sep 16, 2020 · 8 comments
Closed

Add 404 page #102

gokaiorg opened this issue Sep 16, 2020 · 8 comments
Assignees
Labels
design enhancement New feature or request

Comments

@gokaiorg
Copy link
Contributor

No description provided.

@bonustrack
Copy link
Member

Or redirect to homepage

@mktcode
Copy link
Contributor

mktcode commented Jun 15, 2022

#1211 is fixed for spaces.
Others need fix:
https://snapshot.org/#/strategy/asdadadad
https://snapshot.org/#/profile/
https://snapshot.org/#/profile/asdadsasd

Need design for proper 404 page.

@zzuziak
Copy link
Contributor

zzuziak commented Feb 6, 2023

Shall we pick this one up to make sure all edge cases are covered? 🙏 @samuveth

@samuveth
Copy link
Contributor

samuveth commented Feb 7, 2023

@zzuziak need design for this. Or at least some content for the page

@zzuziak
Copy link
Contributor

zzuziak commented Feb 7, 2023

We can also use the redirect to home for now, one option would be to display an alert of what happened after the redirection (URL you are looking for doesn't exist). Wdyt?

@Todmy
Copy link
Contributor

Todmy commented Jun 20, 2023

The solution should be in configuring DO. We need to set catchall_document to index.html:

  1. Using Cloud panel UI: Log in and click on App > Settings >> click on component name > scroll down to Custom page > Edit Custom page and select Catchall > Enter index.html in the page name block > save
  2. Using App Spec: You can the catchall_document to index.html in-app spec.

@samuveth
Copy link
Contributor

The solution should be in configuring DO. We need to set catchall_document to index.html:

  1. Using Cloud panel UI: Log in and click on App > Settings >> click on component name > scroll down to Custom page > Edit Custom page and select Catchall > Enter index.html in the page name block > save
  2. Using App Spec: You can the catchall_document to index.html in-app spec.

@Todmy What you are referring to I think is handling 404 pages on server level. But since we're hosting the frontend on Fleek, which serves static files and doesn't provide server-side configurations, the best approach would be to handle 404 pages directly within the application using Vue Router.

@Todmy
Copy link
Contributor

Todmy commented Jul 28, 2023

@samuveth it cannot be done with the Vue router (only if we change it's type to history). This will require some changes to the hosting provider. After an investigation, I have found a way how to do it #4100. I agree that it's not perfect, but better than nothing.

@ChaituVR ChaituVR reopened this Dec 10, 2023
@ChaituVR ChaituVR closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants