Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the std default feature #147

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Remove the std default feature #147

merged 1 commit into from
Sep 4, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 4, 2023

Added in 272bb11 for reasons that are unclear to me. It serves no purpose aside from disabling the API of the entire crate, so it's best to remove it.

Added in 272bb11 for reasons that are
unclear to me. It serves no purpose aside from disabling the API of the
entire crate, so it's best to remove it.

Signed-off-by: John Nunley <[email protected]>
@notgull notgull mentioned this pull request Sep 4, 2023
@fogti
Copy link
Member

fogti commented Sep 4, 2023

what about the CI change in the original commit? (I checked now, it's no longer present)

@fogti fogti merged commit 90c661f into master Sep 4, 2023
21 checks passed
@fogti fogti deleted the notgull/rm-std-feat branch September 4, 2023 20:15
@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

what about the CI change in the original commit? (I checked now, it's no longer present)

Looks like it was removed in dec94cb when taiki-e was cleaning up the CI configuration

@taiki-e
Copy link
Collaborator

taiki-e commented Sep 5, 2023

This was necessary to add no-std support without requiring a breaking change. (crossbeam-rs/crossbeam#508 (comment) has a more detailed explanation of this.)

However, given that we have decided not to do #87, that may no longer be necessary.

what about the CI change in the original commit? (I checked now, it's no longer present)

Looks like it was removed in dec94cb when taiki-e was cleaning up the CI configuration

That check was not just removed, but replaced with a more robust cargo hack build --feature-powerset --no-dev-deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants