-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.0 #139
v3.0.0 #139
Conversation
@smol-rs/admins Any objections to me publishing this? I do not foresee needing to make any more breaking changes after this. |
None from me. |
Would you add #143 to changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from nits on changelog.
92d852f
to
dff2921
Compare
why is
|
why is |
Good question, I've opened #146 to address it.
This is necessary for |
hmm why does this crate even have an |
Good question. This was added in 272bb11 for reasons that elude me; maybe it was meant to port this crate to not require I can remove it. |
Remove it. |
Ok, done in #147 |
Signed-off-by: John Nunley <[email protected]>
dff2921
to
4003f31
Compare
libc
in all backends with therustix
crate (Replace libc with rustix in some backends #108, Remove libc from dev deps #146).tracing
instead oflog
for logging (Replace log with tracing #119).Event
partially opaque, and create a newEvents
struct for holding events. (Extract the Events struct and make the Event struct opaque #133)polling
in Linux containers withouteventfd
available. (Add a pipe-based notifier to epoll #134)Poller
s. (Specify behavior when registered in multiple pollers #136)c_int
from the standard library inpolling::os::kqueue
instead of defining our own. (Use std::os::raw::c_int and remove our own type alias #143)