Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 #139

Merged
merged 1 commit into from
Sep 5, 2023
Merged

v3.0.0 #139

merged 1 commit into from
Sep 5, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Aug 20, 2023

@notgull
Copy link
Member Author

notgull commented Sep 3, 2023

@smol-rs/admins Any objections to me publishing this? I do not foresee needing to make any more breaking changes after this.

@zeenix
Copy link
Member

zeenix commented Sep 3, 2023

None from me.

@taiki-e
Copy link
Collaborator

taiki-e commented Sep 4, 2023

Would you add #143 to changelog?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nits on changelog.

@fogti
Copy link
Member

fogti commented Sep 4, 2023

why is libc still in dev-dependencies?

Cargo.toml
53:libc = "0.2"

CHANGELOG.md
23:- Update use of `libc::timespec` to prepare for future libc version (#55)
24:- Update use of `libc::kevent` to prepare for future libc version (#56)
80:- Remove `libc` dependency on Windows.

src/os/kqueue.rs
40:    /// poller.add_filter(Signal(libc::SIGINT), 0, PollMode::Oneshot).unwrap();
63:    /// poller.add_filter(Signal(libc::SIGINT), 0, PollMode::Oneshot).unwrap();
66:    /// poller.modify_filter(Signal(libc::SIGINT), 1, PollMode::Oneshot).unwrap();
89:    /// poller.add_filter(Signal(libc::SIGINT), 0, PollMode::Oneshot).unwrap();
92:    /// poller.delete_filter(Signal(libc::SIGINT)).unwrap();

examples/wait-signal.rs
23:        let sigint = Signal(libc::SIGINT);

@fogti
Copy link
Member

fogti commented Sep 4, 2023

why is rustix pulled in with "std" as a feature?

@notgull notgull mentioned this pull request Sep 4, 2023
@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

why is libc still in dev-dependencies?

Good question, I've opened #146 to address it.

why is rustix pulled in with "std" as a feature?

This is necessary for std::os::fd::BorrowedFd to be used in rustix.

@fogti
Copy link
Member

fogti commented Sep 4, 2023

hmm why does this crate even have an std feature? it doesn't contain any working code if the feature isn't passed...

@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

hmm why does this crate even have an std feature?

Good question. This was added in 272bb11 for reasons that elude me; maybe it was meant to port this crate to not require libstd at some point. Although std::os::fd::* is necessary to register sources, so it doesn't really seem all too relevant to me.

I can remove it.

@fogti
Copy link
Member

fogti commented Sep 4, 2023

Remove it.

@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

Remove it.

Ok, done in #147

@fogti
Copy link
Member

fogti commented Sep 4, 2023

ok, ChangeLog should be updated to include #146 and #147.
was the "std" feature present in some proper release? Yes, since v2.3.0.

Signed-off-by: John Nunley <[email protected]>
@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

ok, ChangeLog should be updated to include #146 and #147. was the "std" feature present in some proper release? Yes, since v2.3.0.

#146 only affected dev dependencies, so it shouldn't be put in the user facing changelog. I added #147 though.

@notgull notgull merged commit 2565423 into master Sep 5, 2023
24 checks passed
@notgull notgull deleted the notgull/next branch September 5, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants