Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] move tests for dependency checks and deep_equals to utils module #217

Merged
merged 7 commits into from
Aug 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skbase/testing/test_all_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
from skbase.testing.utils._conditional_fixtures import (
create_conditional_fixtures_and_names,
)
from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.testing.utils.inspect import _get_args
from skbase.utils.deep_equals import deep_equals
from skbase.utils.dependencies import _check_soft_dependencies

__author__: List[str] = ["fkiraly"]

Expand Down
2 changes: 0 additions & 2 deletions skbase/testing/utils/tests/__init__.py

This file was deleted.

2 changes: 1 addition & 1 deletion skbase/tests/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
import scipy.sparse as sp

from skbase.base import BaseEstimator, BaseObject
from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.tests.conftest import Child, Parent
from skbase.tests.mock_package.test_mock_package import CompositionDummy
from skbase.utils.dependencies import _check_soft_dependencies


# TODO: Determine if we need to add sklearn style test of
Expand Down
2 changes: 2 additions & 0 deletions skbase/utils/dependencies/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# -*- coding: utf-8 -*-
"""Testing utilities for depeendency checkers."""
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest
from packaging.requirements import InvalidRequirement

from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.utils.dependencies._dependencies import _check_soft_dependencies


def test_check_soft_deps():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import numpy as np
import pytest

from skbase.testing.utils._dependencies import _check_soft_dependencies
from skbase.utils.deep_equals import deep_equals
from skbase.utils.dependencies import _check_soft_dependencies

# examples used for comparison below
EXAMPLES = [
Expand Down
Loading