Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] move tests for dependency checks and deep_equals to utils module #217

Merged
merged 7 commits into from
Aug 26, 2023

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Aug 26, 2023

This PR moves the tests for dependency checks and deep_equals to the utils module where those utilities reside.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Merging #217 (deb52fa) into main (d840e75) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          43       43           
  Lines        2841     2841           
=======================================
  Hits         2375     2375           
  Misses        466      466           
Files Changed Coverage Δ
skbase/testing/test_all_objects.py 79.43% <100.00%> (ø)
skbase/utils/dependencies/tests/__init__.py 100.00% <100.00%> (ø)
...tils/dependencies/tests/test_check_dependencies.py 100.00% <100.00%> (ø)
skbase/utils/tests/test_deep_equals.py 100.00% <100.00%> (ø)

@fkiraly fkiraly merged commit cd7bec6 into main Aug 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants