[c++] Fix ManagedQuery usage in SOMAArray write path
#2975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenv
changed the title
ManagedQuery usage in SOMAArray writepathManagedQuery usage in SOMAArray write path
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
+ Coverage 89.64% 89.79% +0.14%
==========================================
Files 39 39
Lines 4096 4096
==========================================
+ Hits 3672 3678 +6
+ Misses 424 418 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
force-pushed
the
viviannguyen/use-array-buffers-in-write-path
branch
from
981b32b
to
a27271d
Compare
This was referenced Sep 11, 2024
nguyenv
force-pushed
the
viviannguyen/use-array-buffers-in-write-path
branch
from
a27271d
to
bbde4d6
Compare
nguyenv
force-pushed
the
viviannguyen/use-array-buffers-in-write-path
branch
from
bbde4d6
to
9d65d57
Compare
|
All changes encompassed by #2989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2928
Changes:
Notes for Reviewer:
Will split this into smaller PRs