Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Create specialized templates for SOMAArray casting functions #2982

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Sep 12, 2024

Issue and/or context:

#2975

This is the second of multiple PRs that will be split out from above

Changes:

This is just code reorganization for cleaning up switch-case statements. Create specialized templates for types that need special handling when casting into write buffers. For strings, we need to deal with different size offset buffers depending on whether the user passed in large_string or regular string. For Boolean, we need to convert from Arrow (bit) to TileDB (uint8_t) representation.

@nguyenv nguyenv marked this pull request as ready for review September 12, 2024 00:05
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (7039921) to head (c5fe5aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
+ Coverage   89.73%   89.87%   +0.14%     
==========================================
  Files          39       39              
  Lines        4080     4080              
==========================================
+ Hits         3661     3667       +6     
+ Misses        419      413       -6     
Flag Coverage Δ
python 89.87% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.87% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit 753d9f7 into main Sep 12, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/specialize-templates-for-casting branch September 12, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants