FIX Check canArchive() permission instead of canDelete() #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Aug 6, 2024
Comment on lines
573
to
575
| // note there isn't a canDelete() test here because it seems impossible to get an | ||
| // unversioned Link because there's no way to actually remove the Versioned extension | ||
| // from any subclass of Link since we're unable to the use app/_config.php method |
There was a problem hiding this comment.
Why can't you just use MyLinkSubclass::remove_extension(Versioned::class); in the test?
emteknetnz
force-pushed
the
pulls/4.0/can-archive
branch
from
2ba2e3c
to
3a16300
Compare
emteknetnz
force-pushed
the
pulls/4.0/can-archive
branch
from
3a16300
to
05f0bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #291