canArchive() is not called before archiving versioned links

[GuySartorelli]

Note that this has been looked at from a security standpoint, and the CMS Squad has decided it does not constitute a security issue under our current security process.

‎‎LinkFieldController::linkDelete() checks canDelete(), but for versioned records it doesn't check canArchive. It does have version-aware logic to call doArchive() instead of delete(), so it should also use the correct permission check.

Acceptance criteria

• For versioned links, the canArchive() permission method is called
• For non-versioned links, the canDelete() permission method is called

PRs

• FIX Check canArchive() permission instead of canDelete() #315

[GuySartorelli]

PR merged