Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple things in EditHandler #308

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Sep 19, 2024

Description

This PR fixes multiple things in the EditHandler

Manual testing steps

Edit multiple items and see that it works :)

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

->setAttribute('data-icon', 'accept')
// ->setAttribute('data-icon', 'accept')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't comment out code. If it shouldn't be there, remove it entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i commented them because maybe it's possible to find the right attribute to set the proper icons but currently it's not working great as you can see in my screenshot :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the time to find out if there's an appropriate attribute and set it, please do it in this PR - otherwise please remove the commented-out code.

src/BulkManager/BulkAction/EditHandler.php Outdated Show resolved Hide resolved
@lekoala
Copy link
Contributor Author

lekoala commented Sep 30, 2024

@GuySartorelli icons fixed, syntax updated

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great locally. Thanks for doing this!

@GuySartorelli GuySartorelli merged commit bef2090 into silverstripe:4.0 Sep 30, 2024
5 checks passed
@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants