-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple things in EditHandler #308
Conversation
->setAttribute('data-icon', 'accept') | ||
// ->setAttribute('data-icon', 'accept') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't comment out code. If it shouldn't be there, remove it entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i commented them because maybe it's possible to find the right attribute to set the proper icons but currently it's not working great as you can see in my screenshot :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the time to find out if there's an appropriate attribute and set it, please do it in this PR - otherwise please remove the commented-out code.
@GuySartorelli icons fixed, syntax updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works great locally. Thanks for doing this!
Description
This PR fixes multiple things in the EditHandler
Manual testing steps
Edit multiple items and see that it works :)
Issues
Pull request checklist