Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CMS layout widths when bulk editing #295

Closed
wants to merge 1 commit into from

Conversation

kinglozzer
Copy link
Member

@kinglozzer kinglozzer commented Jul 8, 2024

Description

The edit form is missing the necessary CSS class to ensure its width is consistent with other CMS sections.

Before:
Screenshot 2024-07-08 at 11 33 50

After:
Screenshot 2024-07-08 at 11 33 57

Manual testing steps

Bulk edit something. My edit form includes an UploadField, not sure if that's relevant in triggering this, but it's definitely more noticeable at smaller screen sizes.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli GuySartorelli mentioned this pull request Jul 9, 2024
2 tasks
@GuySartorelli
Copy link
Member

Thanks for raising this!

Since this is a commercially supported module, and commercial support for CMS 4 is now in "security patches only" phase, I can't merge this against the branch it's currently targetting without @colymba saying they're okay with a patch release for the CMS 4 compatible versions.

The alternative would be to retarget this PR to 4.0.

@lekoala lekoala mentioned this pull request Sep 19, 2024
8 tasks
@lekoala
Copy link
Contributor

lekoala commented Sep 19, 2024

the edit handler is really broken at the moment see #308

for the layout specifically, it also needs fill-height

would be great to have a working feature for the current silverstripe version :)

@GuySartorelli
Copy link
Member

Closing in favour of #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants