Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Added fileID and record variables to onBulkUpload hook (Revision 2) #303

Merged

Conversation

mooror
Copy link

@mooror mooror commented Aug 19, 2024

Description

This PR adds the $fileID and $record variables to the "onBulkUpload" extension point that is in the createDataObject() method (in BulkUploadHandler.php). This allows developers to easily set additional fields on the newly created records and use data from the uploaded file to do so.

See the related issue for a usage example

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Replaces

@mooror mooror changed the title API Added fileID and record variables to onBulkUpload hook (New) API Added fileID and record variables to onBulkUpload hook (Revision 2) Aug 19, 2024
@mooror
Copy link
Author

mooror commented Aug 19, 2024

Let me know if this PR needs tests. I have never done one before, but I am willing to learn if needed

@GuySartorelli
Copy link
Member

Thanks for doing that.
No tests needed - everything that already worked will still work, this just gives some additional arguments that people can opt into using when they implement the onBulkUpload extension hook method.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 4bd3542 into silverstripe:4 Aug 19, 2024
5 checks passed
@mooror
Copy link
Author

mooror commented Aug 20, 2024

Thanks for doing that. No tests needed - everything that already worked will still work, this just gives some additional arguments that people can opt into using when they implement the onBulkUpload extension hook method.

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants