Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fileID and record variables to onBulkUpload hook (revision 1) #302

Closed
wants to merge 1 commit into from

Conversation

mooror
Copy link

@mooror mooror commented Aug 19, 2024

Description

This PR adds the $fileID and $record variables to the "onBulkUpload" extension point that is in the createDataObject() method (in BulkUploadHandler.php). This allows developers to easily set additional fields on the newly created records and use data from the uploaded file to do so.

See the related issue for a usage example

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@mooror
Copy link
Author

mooror commented Aug 19, 2024

Replaces #297

@mooror
Copy link
Author

mooror commented Aug 19, 2024

@GuySartorelli So I think I did the change correctly this time. I followed your instructions and started again, this time from the 4 branch. Made my changes and created a PR for the 4 branch.

A few things I don't know:

  1. I forgot to add "API" to the beginning of the commit. Do you want me to change that, and if so, is there a simple way to rename a commit in a PR?
  2. Does this change require tests? I haven't written a test before, but I would be willing to learn if needed

@mooror mooror changed the title Added fileID and record variables to onBulkUpload hook Added fileID and record variables to onBulkUpload hook (New) Aug 19, 2024
@mooror mooror closed this Aug 19, 2024
@mooror
Copy link
Author

mooror commented Aug 19, 2024

The quickest way I knew of to fix the commit text was to redo it, so I made another PR with the commit text changed.

Sorry about that

@mooror
Copy link
Author

mooror commented Aug 19, 2024

Replaced by #303

@mooror mooror changed the title Added fileID and record variables to onBulkUpload hook (New) Added fileID and record variables to onBulkUpload hook (replaced) Aug 19, 2024
@mooror mooror changed the title Added fileID and record variables to onBulkUpload hook (replaced) Added fileID and record variables to onBulkUpload hook (replaced by #303) Aug 19, 2024
@mooror mooror changed the title Added fileID and record variables to onBulkUpload hook (replaced by #303) Added fileID and record variables to onBulkUpload hook (revision 1) Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant