Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend assetlist schema with optional type_asset field #27

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Extend assetlist schema with optional type_asset field #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb1aa4
Add type_asset to assetlist
besated Nov 16, 2023
42fca16
Update existing tokens in assetlist with type_asset
besated Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions assetlist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/axelar/images/usdc.svg",
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/axelar/images/usdc.png"
},
"coingecko_id": "axlusdc"
"coingecko_id": "axlusdc",
"type_asset": "ics20"
},
{
"name": "Osmosis",
Expand All @@ -82,7 +83,8 @@
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/osmosis/images/osmo.png",
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/osmosis/images/osmo.svg"
},
"coingecko_id": "osmosis"
"coingecko_id": "osmosis",
"type_asset": "ics20"
},
{
"name": "Atom (Osmosis)",
Expand All @@ -104,7 +106,8 @@
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/cosmoshub/images/atom.png",
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/cosmoshub/images/atom.svg"
},
"coingecko_id": "cosmos"
"coingecko_id": "cosmos",
"type_asset": "ics20"
},
{
"name": "Atom",
Expand All @@ -126,7 +129,8 @@
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/cosmoshub/images/atom.png",
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/cosmoshub/images/atom.svg"
},
"coingecko_id": "cosmos"
"coingecko_id": "cosmos",
"type_asset": "ics20"
},
{
"name": "Wrapped Ether (Wormhole)",
Expand Down Expand Up @@ -393,11 +397,11 @@
"name": "PKS",
"description": "Poker Kings Token",
"symbol": "PKS",
"base": "cw20:sei1eavtmc4y00a0ed8l9c7l0m7leesv3yetcptklv2kalz4tsgz02mqlvyea6",
"base": "sei1eavtmc4y00a0ed8l9c7l0m7leesv3yetcptklv2kalz4tsgz02mqlvyea6",
"display": "PKS",
"denom_units": [
{
"denom": "cw20:sei1eavtmc4y00a0ed8l9c7l0m7leesv3yetcptklv2kalz4tsgz02mqlvyea6",
"denom": "sei1eavtmc4y00a0ed8l9c7l0m7leesv3yetcptklv2kalz4tsgz02mqlvyea6",
"exponent": 0
},
{
Expand All @@ -408,7 +412,7 @@
"images": {
"svg": "https://cloudflare-ipfs.com/ipfs/QmPk6YGTMfmCpHKpb18HeASg3H2iQSd4HiGvdH8zz6ZBkM"
},
"coingecko_id": ""
"type_asset": "cw20"
}
],
"atlantic-2": [
Expand Down Expand Up @@ -553,7 +557,8 @@
"images": {
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/axelar/images/usdc.svg",
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/axelar/images/usdc.png"
}
},
"type_asset": "ics20"
},
{
"name": "Wrapped Matic",
Expand All @@ -574,7 +579,8 @@
"images": {
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/polygon/images/wmatic.png",
"svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/polygon/images/wmatic.svg"
}
},
"type_asset": "ics20"
}
],
"sei-devnet-3": [
Expand Down
9 changes: 8 additions & 1 deletion schema/assetlist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@
}
},
"coingecko_id": {
"type": "string"
"type": "string",
"description": "[OPTIONAL] The coingecko id to fetch asset data from coingecko v3 api. See https://api.coingecko.com/api/v3/coins/list"
},
"type_asset": {
"type": "string",
"enum": ["sdk.coin", "cw20", "erc20", "ics20"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add token factory here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tokenfactory denoms are actually just sdk.Coins, so I think it should be categorized as sdk.coin instead of a separate type

"default": "sdk.coin",
"description": "[OPTIONAL] The potential options for type of asset. By default, assumes sdk.coin"
}
},
"required": [
Expand Down
Loading