Extend assetlist schema with optional type_asset field #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebycarson
approved these changes
Nov 16, 2023
| }, | ||
| "type_asset": { | ||
| "type": "string", | ||
| "enum": ["sdk.coin", "cw20", "erc20", "ics20"], |
There was a problem hiding this comment.
Should we add token factory here?
There was a problem hiding this comment.
Tokenfactory denoms are actually just sdk.Coins, so I think it should be categorized as sdk.coin instead of a separate type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional field to the assetlist schema,
type_asset. This field allows us to differentiate between various token types such as sdk.coin, ics20, and cw20. This field already exists in the Cosmo's chain registry.These changes aim to improve the classification and management of different token types within our system, ensuring it remains adaptable and robust. The inclusion of this field allows for more precise identification and handling of these token types in our processes.