Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[machine-image] add backport automation #541

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

yaronkaikov
Copy link
Collaborator

Similar to what we have in Scylla-pkg, adding relevant automation scripts and workflow so we can easly do backports

Similar to what we have in Scylla-pkg, adding relevant automation
scripts and workflow so we can easly do backports
Copy link
Collaborator

@Annamikhlin Annamikhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaronkaikov yaronkaikov merged commit 8ae34d0 into scylladb:next Sep 17, 2024
1 check passed
@yaronkaikov yaronkaikov deleted the add-automation branch September 17, 2024 08:26
yaronkaikov added a commit to yaronkaikov/scylla-machine-image that referenced this pull request Sep 18, 2024
In this commit there few improvments to the backport automation process
based on the work done in scylladb#541

1. Create new parameter `--commit` to be use only when `--pull-request`
   is provided
2. Trigger workflow when label is `backport/x.y` only, rather then
   `backport/` as it was defined before. This way we will not trigger to
flow when `backport/x.y-done` was added
3. when running on specific PR with `--pull-request` make sure we don't
   pass an empty commit
4. fix `get_prs_from_commits()` while trying to do `get_commit` on the
   wrong sha1 value
yaronkaikov added a commit that referenced this pull request Sep 19, 2024
In this commit there few improvments to the backport automation process
based on the work done in #541

1. Create new parameter `--commit` to be use only when `--pull-request`
   is provided
2. Trigger workflow when label is `backport/x.y` only, rather then
   `backport/` as it was defined before. This way we will not trigger to
flow when `backport/x.y-done` was added
3. when running on specific PR with `--pull-request` make sure we don't
   pass an empty commit
4. fix `get_prs_from_commits()` while trying to do `get_commit` on the
   wrong sha1 value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants