[.github/scripts/auto-backport.py] improve label logic #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit there few improvments to the backport automation process based on the work done in scylladb#541 1. Create new parameter `--commit` to be use only when `--pull-request` is provided 2. Trigger workflow when label is `backport/x.y` only, rather then `backport/` as it was defined before. This way we will not trigger to flow when `backport/x.y-done` was added 3. when running on specific PR with `--pull-request` make sure we don't pass an empty commit 4. fix `get_prs_from_commits()` while trying to do `get_commit` on the wrong sha1 value
yaronkaikov
force-pushed
the
sync-automation
branch
from
d9b3cdd
to
b629029
Compare
Annamikhlin
approved these changes
Sep 19, 2024
|
@yaronkaikov are you gonna apply those on dtest/sct as well ? |
yep, soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit there few improvments to the backport automation process based on the work done in #541
--committo be use only when--pull-requestis providedbackport/x.yonly, rather thenbackport/as it was defined before. This way we will not trigger to flow whenbackport/x.y-donewas added--pull-requestmake sure we don't pass an empty commitget_prs_from_commits()while trying to doget_commiton the wrong sha1 value