-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: add t3.micro as dev-mode instance #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benipeled
force-pushed
the
support_aws_dev_instances
branch
from
September 20, 2023 17:48
92d6a88
to
1e107e1
Compare
Verified with https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/next-machine-image/192 AWS t3.micro |
yaronkaikov
approved these changes
Sep 20, 2023
benipeled
force-pushed
the
support_aws_dev_instances
branch
from
September 21, 2023 04:36
1e107e1
to
d410154
Compare
benipeled
added
Needs backport 5.2
backport/2023.1
and removed
Needs backport 5.2
labels
Sep 21, 2023
juliayakovlev
added a commit
to juliayakovlev/scylla-cluster-tests
that referenced
this pull request
Oct 3, 2023
The change is presented in https://github.com/scylladb/scylla-cluster-tests/pull/6566/commits/ e49c4f4 added '--developer-mode' scylla argument for t3.micro artifact test. But later '--developer-mode' agrument was added to be default by scylladb/scylla-machine-image#482. As result https://jenkins.scylladb.com/job/enterprise-2023.1/job/artifacts/job/artifacts-ami-t3_micro-test/ fails with error: scylla[4265]: FATAL: Exception during startup, aborting: boost::wrapexcept<boost::program_options:: multiple_occurrences> (option '--developer-mode' cannot be specified more than once) Remove '--developer-mode' arg.
Merged
7 tasks
fruch
pushed a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Oct 3, 2023
The change is presented in https://github.com/scylladb/scylla-cluster-tests/pull/6566/commits/ e49c4f4 added '--developer-mode' scylla argument for t3.micro artifact test. But later '--developer-mode' agrument was added to be default by scylladb/scylla-machine-image#482. As result https://jenkins.scylladb.com/job/enterprise-2023.1/job/artifacts/job/artifacts-ami-t3_micro-test/ fails with error: scylla[4265]: FATAL: Exception during startup, aborting: boost::wrapexcept<boost::program_options:: multiple_occurrences> (option '--developer-mode' cannot be specified more than once) Remove '--developer-mode' arg.
fruch
pushed a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Oct 3, 2023
The change is presented in https://github.com/scylladb/scylla-cluster-tests/pull/6566/commits/ e49c4f4 added '--developer-mode' scylla argument for t3.micro artifact test. But later '--developer-mode' agrument was added to be default by scylladb/scylla-machine-image#482. As result https://jenkins.scylladb.com/job/enterprise-2023.1/job/artifacts/job/artifacts-ami-t3_micro-test/ fails with error: scylla[4265]: FATAL: Exception during startup, aborting: boost::wrapexcept<boost::program_options:: multiple_occurrences> (option '--developer-mode' cannot be specified more than once) Remove '--developer-mode' arg. (cherry picked from commit 3262654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the dev-mode instances support was added on #479
This change adds the t3.micro as AWS dev-mode instance
cc @carlosms