Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifact test): remove 'developer-mode' arg for t3.micro #6646

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

juliayakovlev
Copy link
Contributor

The change is presented in https://github.com/scylladb/scylla-cluster-tests/pull/6566/commits/ e49c4f4 added '--developer-mode' scylla argument for t3.micro artifact test.

But later '--developer-mode' agrument was added to be default by scylladb/scylla-machine-image#482.

As result
https://jenkins.scylladb.com/job/enterprise-2023.1/job/artifacts/job/artifacts-ami-t3_micro-test/ fails with error:

scylla[4265]: FATAL: Exception during startup, aborting: boost::wrapexcept<boost::program_options:: multiple_occurrences> (option '--developer-mode' cannot be specified more than once)

Remove '--developer-mode' arg.

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

The change is presented in https://github.com/scylladb/scylla-cluster-tests/pull/6566/commits/
e49c4f4 added '--developer-mode' scylla argument for
t3.micro artifact test.

But later '--developer-mode' agrument was added to be default by
scylladb/scylla-machine-image#482.

As result
https://jenkins.scylladb.com/job/enterprise-2023.1/job/artifacts/job/artifacts-ami-t3_micro-test/
fails with error:

scylla[4265]: FATAL: Exception during startup, aborting: boost::wrapexcept<boost::program_options::
multiple_occurrences> (option '--developer-mode' cannot be specified more than once)

Remove '--developer-mode' arg.
@juliayakovlev juliayakovlev added the backport/2023.1 Need to backport to 2023.1 label Oct 3, 2023
@juliayakovlev
Copy link
Contributor Author

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 3262654 into scylladb:master Oct 3, 2023
6 checks passed
@fruch fruch added the backport/2023.1-done Commit backported to 2023.1 label Oct 3, 2023
@juliayakovlev
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants