-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scrapy-poet #156
Bump scrapy-poet #156
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 11 11
Lines 812 812
=======================================
Hits 801 801
Misses 11 11 |
There is another thing we need to change here though: https://scrapy-zyte-api.readthedocs.io/en/latest/usage/scrapy-poet.html#default-parameters says "Note that the built-in scrapy_poet.page_input_providers.ItemProvider has a priority of 2000, so when you have page objects producing zyte_common_items.Product items you should use higher values for ZyteApiProvider if you want these items to come from these page objects, and lower values if you want them to come from Zyte API." Now I think the items will always come from the page objects and if you want to get them directly you need to change the rules? |
I think to get them directly you should disable the corresponding rule altogether. But honestly, I think the “right” behavior is for items to come from a page object when one exists, so I think we can simply remove that paragraph altogether and not document what to do for the other behavior, at least until we find a real use case for it that we want to support (which might require code changes). |
Fixes #91
Not sure if we should make a new release just with this.