Merge pull request #156 from scrapy-plugins/double-requests

Bump scrapy-poet

docs/usage/scrapy-poet.rst

@@ -53,20 +53,6 @@ set the default options for various extraction types, e.g.::
         "productNavigationOptions": {"extractFrom": "httpResponseBody"},
     }
 
-Note that the built-in ``scrapy_poet.page_input_providers.ItemProvider`` has a
-priority of 2000, so when you have page objects producing
-:class:`zyte_common_items.Product` items you should use higher values for
-``ZyteApiProvider`` if you want these items to come from these page objects,
-and lower values if you want them to come from Zyte API.
-
-Currently, when ``ItemProvider`` is used together with ``ZyteApiProvider``,
-it may make more requests than is optimal: the normal Scrapy response will be
-always requested even when using a :class:`~scrapy_poet.DummyResponse`
-annotation, and in some dependency combinations two Zyte API requests will be
-made for the same page. We are planning to solve these problems in the future
-releases of :doc:`scrapy-poet <scrapy-poet:index>` and scrapy-zyte-api.
-
-
 Dependency annotations
 ======================
 

setup.py

@@ -28,10 +28,10 @@ def get_version():
         "zyte-api>=0.4.8",
     ],
     extras_require={
-        # Sync with [testenv:provider-pinned] @ tox.ini
+        # Sync with [testenv:pinned-provider] @ tox.ini
         "provider": [
-            "andi>=0.5.0",
-            "scrapy-poet>=0.18.0",
+            "andi>=0.6.0",
+            "scrapy-poet>=0.19.0",
             "web-poet>=0.15.1",
             "zyte-common-items>=0.7.0",
         ]

tests/test_providers.py

@@ -117,8 +117,6 @@ def parse_(  # type: ignore[override]
     assert "product" in item
 
 
-# https://github.com/scrapy-plugins/scrapy-zyte-api/issues/91
-@pytest.mark.xfail(reason="Not implemented yet", raises=AssertionError, strict=True)
 @ensureDeferred
 async def test_itemprovider_requests_indirect_dependencies(fresh_mockserver):
     class ItemDepSpider(ZyteAPISpider):

tox.ini

@@ -88,7 +88,8 @@ extras = provider
 deps =
     # scrapy-poet >= 0.4.0 depends on scrapy >= 2.6.0
     {[testenv:pinned-scrapy-2x6]deps}
-    scrapy-poet==0.18.0
+    andi==0.6.0
+    scrapy-poet==0.19.0
     web-poet==0.15.1
     zyte-common-items==0.7.0