Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support media queries with widths expressed in rem. #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graaff
Copy link

@graaff graaff commented Sep 18, 2014

Add rem to the regular expressions for width-based media queries. This
was already discussed in #18 but not implemented as part of this change.

Tested with IE8 where this works as expected.

Add rem to the regular expressions for width-based media queries. This
was already discussed in scottjehl#18 but not implemented as part of this change.
@nbouvrette
Copy link

nbouvrette commented Jun 4, 2017

Is there any reason this is not merged? I tested it and it works fine. This would also solve scenarios that https://github.com/chuckcarpenter/REM-unit-polyfill does not support today.

@nbouvrette
Copy link

nbouvrette commented Jun 9, 2017

Actually it look like REM-unit-polyfill has open issues and does not play nice with Respondjs. The solution you provided in this pull request will not function completely. For full REM support, please look into this solution: https://github.com/nbouvrette/remPolyfill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants