Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

media query #60

Closed
wtayyeb opened this issue Aug 12, 2015 · 4 comments
Closed

media query #60

wtayyeb opened this issue Aug 12, 2015 · 4 comments

Comments

@wtayyeb
Copy link

wtayyeb commented Aug 12, 2015

Hi,

Why this polyfill not fixing rems inside media queries?
I know media queries are not supported in IE6-8 but great polyfills exists to solve that like https://github.com/scottjehl/Respond/

I think you could check if that polyfill or simillars are exist or check browser support for media-queries then do rem2px exchange in stylesheets.

Thanks

@chuckcarpenter
Copy link
Owner

@wtayyeb we'd happily accept a pull request for that type of support, but the decision was made awhile ago to ignore MQ rules when the polyfill was kicked in, since support would only be required at desktop. The discussion for that is here, #13 (brought up by respond.js) and implementation here: #20.

@nbouvrette
Copy link

May I suggest to reconsider not implementing this features? A lot of sites are using "mobile first" which means that using your polyfill and respond.js will render the mobile version of the site.

@nbouvrette
Copy link

Actually it looks like the fix is pending merge in Respond.js : scottjehl/Respond#302

@nbouvrette
Copy link

If you ever want to implement this feature in your solution, please look at my solution which required a custom Respondjs : https://github.com/nbouvrette/remPolyfill (but please also fix the open issues).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants