Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #33 - Avoid unused click handlers for images #34

Merged
merged 6 commits into from
Oct 10, 2021
Merged

fix issue #33 - Avoid unused click handlers for images #34

merged 6 commits into from
Oct 10, 2021

Commits on Oct 9, 2021

  1. Replace var with const / let to restrict scope

    @BePo65
    BePo65 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    20e0faf View commit details
    Browse the repository at this point in the history

  2. Add missing comments

    @BePo65
    BePo65 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    5e6c065 View commit details
    Browse the repository at this point in the history

  3. Harmonize style 

    consistent (single) quotes
consistent indentation
consistent curly brackets
no dangling commas
    @BePo65
    BePo65 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    240a8ac View commit details
    Browse the repository at this point in the history

  4. Add base to parseInt

    @BePo65
    BePo65 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    753142e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2021

  1. explicitly convert numbers to string if needed

    @BePo65
    BePo65 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    8fc0f08 View commit details
    Browse the repository at this point in the history

  2. feature: add onClickHandler only if needed 

    Changed default value of onClickHandler setting to null and added click
handler to ProgressiveImage element only, if there is an onClickHandler.
This way no unused click handler is added to image.
    @BePo65
    BePo65 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    7d9b67e View commit details
    Browse the repository at this point in the history