fix issue #33 - Avoid unused click handlers for images #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent (single) quotes consistent indentation consistent curly brackets no dangling commas
Changed default value of onClickHandler setting to null and added click handler to ProgressiveImage element only, if there is an onClickHandler. This way no unused click handler is added to image.
BePo65
force-pushed
the
pu/reduceClickHandlers
branch
from
34b02f7
to
7d9b67e
Compare
|
Thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation / basis for a pr that solves issue #29 and improves pr #18 this pr avoids unused click handlers for the images (and harmonizes some code styles).