Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Radius to accept params #190

Merged
merged 7 commits into from
Mar 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: SeuratObject
Type: Package
Title: Data Structures for Single Cell Data
Version: 5.0.1.9004
Version: 5.0.1.9005
Authors@R: c(
person(given = 'Paul', family = 'Hoffman', email = '[email protected]', role = 'aut', comment = c(ORCID = '0000-0002-7693-8957')),
person(given = 'Rahul', family = 'Satija', email = '[email protected]', role = c('aut', 'cre'), comment = c(ORCID = '0000-0001-9448-8833')),
Expand Down Expand Up @@ -36,7 +36,7 @@ BugReports: https://github.com/satijalab/seurat-object/issues
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
Additional_repositories:
https://bnprks.r-universe.dev
Depends:
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased

## Changes:
- Add `...` to call signature for `Radius` generic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add `...` to call signature for `Radius` generic
- Add `...` to call signature for `Radius` generic (#190)

- Properly re-export `%||%` from rlang (#178)
- Class key-based warnings (#180)
- Require R 4.1 (#180)
Expand Down
2 changes: 1 addition & 1 deletion R/centroids.R
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ GetTissueCoordinates.Centroids <- function(object, full = TRUE, ...) {
#' @method Radius Centroids
#' @export
#'
Radius.Centroids <- function(object) {
Radius.Centroids <- function(object, ...) {
return(slot(object = object, name = 'radius'))
}

Expand Down
2 changes: 1 addition & 1 deletion R/generics.R
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,7 @@ Project <- function(object, ...) {
#'
#' @concept spatialimage
#'
Radius <- function(object) {
Radius <- function(object, ...) {
UseMethod(generic = 'Radius', object = object)
}

Expand Down
2 changes: 1 addition & 1 deletion R/spatial.R
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ Key.SpatialImage <- function(object, ...) {
#' @method Radius SpatialImage
#' @export
#'
Radius.SpatialImage <- function(object) {
Radius.SpatialImage <- function(object, ...) {
return(NULL)
}

Expand Down
2 changes: 1 addition & 1 deletion man/Centroids-methods.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/Radius.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/SpatialImage-methods.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.