Allow Radius to accept params #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gesmira
approved these changes
Mar 22, 2024
mojaveazure
requested changes
Mar 22, 2024
mojaveazure
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Great, thanks! This looks good; I've added one suggestion to add the PR number to NEWS.md to auto-link back to it on the pkgdown docs. Also, remember to pin the SeuratObject version to SeuratObject (>= 5.0.1.9005) (allowed on CRAN) in DESCRIPTION on Seurat's develop version whenever you get around to adding the ... and other arguments over there to ensure generic <> method consistency (again, for every method of Radius that Seurat defines)
| @@ -1,6 +1,7 @@ | |||
| # Unreleased | |||
|
|
|||
| ## Changes: | |||
| - Add `...` to call signature for `Radius` generic | |||
There was a problem hiding this comment.
Suggested change
| - Add `...` to call signature for `Radius` generic | |
| - Add `...` to call signature for `Radius` generic (#190) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables concrete implementations of
Radiusto take in parameters by adding...to the generic's signature. Adding ascaleparameter toRadius.VisiumV1defined inSeuratwould help to enable users to plot with the "tissue_hires_image.png" from Visium datasets.