Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs for @import/global builtins deprecations #2004

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Update specs for @import/global builtins deprecations #2004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61ced13
Migrate new color tests
jathak Oct 14, 2024
c0f9890
Add warnings
jathak Oct 14, 2024
9924d9d
Split file that's too long now
jathak Oct 14, 2024
0929427
Disable additional futureDeprecations tests
jathak Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js-api-spec/deprecations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ describe('an error', () => {
});
});

// TODO(jathak): Disable these tests when there aren't any future deprecations.
describe('for a future deprecation,', () => {
// Excluding these tests since there aren't any future deprecations currently.
xdescribe('for a future deprecation,', () => {
let importer: Importer;
beforeEach(() => {
importer = {
Expand Down
3 changes: 2 additions & 1 deletion js-api-spec/legacy/render.node.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,8 @@ describe('options', () => {
});
});

describe('futureDeprecations', () => {
// Disabled since there aren't any current future deprecations
xdescribe('futureDeprecations', () => {
it('opts into future deprecation early', () => {
sandbox(dir => {
dir.write({
Expand Down
24 changes: 24 additions & 0 deletions spec/core_functions/color/adjust/global.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ a {
b: #cd0000;
}

<===> legacy/warning
DEPRECATION WARNING: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.

More info and automated migrator: https://sass-lang.com/d/import

,
1 | a {b: adjust-color(red, $red: -50)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 1:7 root stylesheet

<===>
================================================================================
<===> non_legacy/input.scss
Expand All @@ -15,3 +27,15 @@ a {b: change-color(pink, $chroma: 0.01, $space: oklch)}
a {
b: rgb(217.7587741846, 208.8497862891, 210.1600712342);
}

<===> non_legacy/warning
DEPRECATION WARNING: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.change instead.

More info and automated migrator: https://sass-lang.com/d/import

,
1 | a {b: change-color(pink, $chroma: 0.01, $space: oklch)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 1:7 root stylesheet
Loading
Loading