-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update specs for @import/global builtins deprecations #2004
Conversation
Looks like this also needs |
The following test in it("is converted to a file: URL if it's an absolute Windows path", () => {
const result = compileString('@import "C:/orange";', {
importers: [
{
canonicalize(url: string) {
expect(url).toEqual('file:///C:/orange');
return new URL(`u:${url}`);
},
load: () => ({contents: 'a {b: c}', syntax: 'scss'}),
},
],
});
expect(result.css).toBe('a {\n b: c;\n}');
}); What's weird is that this test works with From what I see this might be for some backward compatibility? As far as I know, every import used to be a path in older implementations, but now is a URI in current implementation. |
That's intended to be import-only behavior. As you surmise, it's a legacy behavior from when we were much more wishy-washy about the distinction between paths and URLs. |
c9eb184
to
c0f9890
Compare
See sass/sass#3898
[skip dart-sass]
[skip sass-embedded]