Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue with PostGIS topology extension #47

Conversation

lwiechec
Copy link

environment variable DB_POSTGIS_TOPOLOGY controls creation of
'postgis_topology' extension only when user selects PostGIS extension.

refs #44

environment variable DB_POSTGIS_TOPOLOGY controls creation of
'postgis_topology' extension _only_ when user selects PostGIS extension.

refs sameersbn#44
@lwiechec lwiechec mentioned this pull request Jan 11, 2016
@lwiechec
Copy link
Author

Hi Sameer,

sorry for creating another pull request but I am not sure how to 'fix' the existing one (and I have a very poor Internet connection right now).

sameersbn pushed a commit that referenced this pull request Jan 11, 2016
fixing issue with PostGIS topology extension
@sameersbn sameersbn merged commit c56e2ce into sameersbn:postgis-extension-finalization Jan 11, 2016
@lwiechec
Copy link
Author

                                                                                  Thanks!                                                                                                                                                                                                                                                                                                                                         Łukasz Wiecheć                                                                                                                                                                                                                 From: Sameer NaikSent: Monday, 11 January 2016 18:00To: sameersbn/docker-postgresqlReply To: sameersbn/docker-postgresqlCc: Lukasz WiechecSubject: Re: [docker-postgresql] fixing issue with PostGIS topology extension (#47)Merged #47.

—Reply to this email directly or view it on GitHub.

@sameersbn
Copy link
Owner

I am concerned about the upgrade path to take when the PostGIS version is updated. Right now it looks like the user will manually need to update as per these instructions http://postgis.net/docs/manual-2.1/postgis_installation.html#soft_upgrade_extensions.

Is there is way that we can detect that a particular database is running an older version of the extension and upgrade it automatically?

Or is this a bad idea and we should leave this to user which would mean that the user will need to keep a watch on the changelog of the image? In which case it might make sense to remove the PG_POSTGIS and other such variables and leave it up to the user to enable extensions manually using the psql cli. In this case we only package the extension with the image, activating/upgrading is left to the user.

My ultimate aim is to have minimal support requests.

edit: one question I had was that I see PostGIS 2.2 is available. Any particular reason you chose 2.1?

@lwiechec
Copy link
Author

Hi Sameer,

I think you are right with assuming that upgrading the PostGIS database
is not a trivial thing. I personally never had to do it, though; that's
why it didn't even go through my head.

There is a way to get the version of the PostGIS from the spatial-enabled
database, you do 'select postgis_lib_version()';. On my 'csd' the database that
runs from your Docker image, I get this:

csd=# select postgis_lib_version();

postgis_lib_version

2.1.8
(1 row)

But even with this, the PostGIS manual is very clear: the data might be
lost, so the best is to dump/import it.

For me it would be great if I could have a quick way to start Docker
containerized PostgreSQL + PostGIS but maybe, from maintainability
perspective, it makes more sense to use 'psql' tool...

Cheers,

Łukasz Wiecheć

Sameer Naik writes:

I am concerned about the upgrade path to take when the PostGIS version
is updated. Right now it looks like the user will manually need to
update as per these instructions
http://postgis.net/docs/manual-2.1/postgis_installation.html#soft_upgrade_extensions.

Is there is way that we can detect that a particular database is
running an older version of the extension and upgrade it
automatically?

Or is this a bad idea and we should leave this to user which would
mean that the user will need to keep a watch on the changelog of the
image? In which case it might make sense to remove the PG_POSTGIS and
other such variables and leave it up to the user to enable extensions
manually using the psql cli. In this case we only package the
extension with the image, activating/upgrading is left to the user.

My ultimate aim is to have minimal support requests.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants