Adding postgis #44
Adding postgis #44
Conversation
normally, to enable PostGIS for a database (including template db),
issuing
CREATE EXTENSION IF NOT EXISTS postgis;
should suffice. However, this is not working in single-user mode (see
http://stackoverflow.com/q/28147177/1547895).
Instead, we are running PostGIS's SQL scripts.
|
Thanks for the PR. Will need a little time to review the changes. Please bear. |
|
|
||
| DB_POSTGIS=${DB_POSTGIS:-false} | ||
| DB_POSTGIS_HSTORE=${DB_POSTGIS_HSTORE:-true} | ||
| DB_POSTGIS_TOPOLOGY=${DB_POSTGIS_TOPOLOGY:-true} |
There was a problem hiding this comment.
I cannot see where DB_POSTGIS_HSTORE and DB_POSTGIS_TOPOLOGY variables are used? Did you intend to commit these variables?
There was a problem hiding this comment.
Hi Sameer,
sorry for sloppiness on my part. I don't know how to fix that in this pull request, so I have created another one.
I decided to drop the hstore extension, as I it looks like it's not a PostGIS specific extension.
|
I extended your work from this PR which can be found in the postgis-extension-finalization branch. Here are the changesets. One important change I have done is that I have removed the use of single-user mode during the setup. The postgres server is now started internally to complete the setup before it is reconfigured to accept external connections. This enables the use of At the moment, the CREATE EXTENSION IF NOT EXISTS postgis;
CREATE EXTENSION IF NOT EXISTS postgis_topologyCan you confirm that these are the only two that should be enabled? I have no experience using PostGIS. Can you please review and test the changes in the postgis-extension-finalization branch before it can be merged into the master? Thank you. |
environment variable DB_POSTGIS_TOPOLOGY controls creation of 'postgis_topology' extension _only_ when user selects PostGIS extension. refs sameersbn#44
|
I just stumbled across this while looking in to building a postgresql container. As basic verification that the postgis stuff works, you could run the following SQL to verify that the extension is indeed installed as a part of your CI tests:
|
|
Hi, this seems to be idle for over a year now, any plan to get it merge ? |
Hi,
I needed to add support for PostGIS spatial extension, so - here it is.
PS: I really like your Docker image as it make is easy to enable clustering etc. Thanks for it!