Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning for long branch names #4426

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Display warning for long branch names #4426

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
326295f
Add warning for branch names exceeding 37 characters
Droniu Nov 13, 2023
1fe6d6c
Add changeset
Droniu Nov 13, 2023
42fa495
Merge branch 'main' into 4425-display-warning-long-branch
Droniu Nov 13, 2023
29500e4
Fix copy
Droniu Nov 13, 2023
ef8ed60
Merge branch 'main' into 4425-display-warning-long-branch
poulch Nov 13, 2023
289344d
Merge branch 'main' into 4425-display-warning-long-branch
Droniu Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-bears-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Display warning for long branch names
10 changes: 10 additions & 0 deletions .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# Maximum allowed branch name length (cloud limit)
Droniu marked this conversation as resolved.
Show resolved Hide resolved
MAX_LENGTH=37

# Check if the branch name length exceeds the maximum allowed length
branch_name=$(git symbolic-ref --short HEAD)
if [ ${#branch_name} -gt $MAX_LENGTH ]; then
echo "⚠️ Warning: Branch name '$branch_name' exceeds the maximum allowed length of $MAX_LENGTH characters."
echo "⚠️ Cloud instance will not be able to deploy."
Droniu marked this conversation as resolved.
Show resolved Hide resolved
fi

npm run check-types
npm run test
Loading