Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning for long branch names #4426

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Nov 13, 2023

closes #4425

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@Droniu Droniu requested a review from a team as a code owner November 13, 2023 11:22
Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 289344d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4425-display-warning-long-branch November 13, 2023 11:23 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4425-display-warning-long-branch November 13, 2023 11:23 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4425-display-warning-long-branch November 13, 2023 11:27 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4425-display-warning-long-branch November 13, 2023 11:27 Destroyed
poulch
poulch previously approved these changes Nov 13, 2023
.husky/pre-push Outdated Show resolved Hide resolved
.husky/pre-push Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to storybook pr-4425-display-warning-long-branch November 13, 2023 11:40 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4425-display-warning-long-branch November 13, 2023 11:40 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4425-display-warning-long-branch November 13, 2023 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4425-display-warning-long-branch November 13, 2023 11:52 Destroyed
poulch added a commit that referenced this pull request Dec 19, 2023
* Add warning for branch names exceeding 37 characters

* Add changeset

* Fix copy

---------

Co-authored-by: Paweł Chyła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Display warning for long branch names
3 participants