src/sage/parallel/map_reduce.py: fixup start_workers() test case #38873
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit a181883 I made this test wait a bit longer (to be more robust under load) and added a "long time" to the corresponding start_workers() line. But, further down, there's another test that calls finish(), which needs the workers to be started. Without a "long time" on the finish(), it can fail sans --long. To fix it, we combine the two tests that call start_workers() and finish(), and then mark the whole thing "long time". The finish() is supposed to delete the workers created in setup_workers() as well, so there's not much point in trying to make the "long time" more fine-grained than that.
|
Documentation preview for this PR (built with commit 94949db; changes) is ready! 🎉 |
|
Lgtm, I will test later. |
|
Let's mark it as CI fix so that it gets applied to the other PRs (where the meson workflow fails due to this problem). |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2024
…s() test case
In commit a181883 I made this test wait a bit longer (to be more robust
under load) and added a "long time" to the corresponding start_workers()
line. But, further down, there's another test that calls finish(), which
needs the workers to be started. Without a "long time" on the finish(),
it can fail sans --long.
To fix it, we combine the two tests that call start_workers() and
finish(), and then mark the whole thing "long time". The finish() is
supposed to delete the workers created in setup_workers() as well, so
there's not much point in trying to make the "long time" more fine-
grained than that.
URL: sagemath#38873
Reported by: Michael Orlitzky
Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit a181883 I made this test wait a bit longer (to be more robust under load) and added a "long time" to the corresponding start_workers() line. But, further down, there's another test that calls finish(), which needs the workers to be started. Without a "long time" on the finish(), it can fail sans --long.
To fix it, we combine the two tests that call start_workers() and finish(), and then mark the whole thing "long time". The finish() is supposed to delete the workers created in setup_workers() as well, so there's not much point in trying to make the "long time" more fine-grained than that.