Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing long time tag to a failing doctest #38891

Closed
wants to merge 1 commit into from

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Oct 31, 2024

To fix

sage -t --warn-long 5.0 --random-seed=279311403945742486210819617974441498089 src/sage/parallel/map_reduce.py
**********************************************************************
File "src/sage/parallel/map_reduce.py", line 1145, in sage.parallel.map_reduce.RESetMapReduce.start_workers
Failed example:
    S.finish()
Exception raised:
    Traceback (most recent call last):
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/doctest/forker.py", line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/doctest/forker.py", line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.parallel.map_reduce.RESetMapReduce.start_workers[4]>", line 1, in <module>
        S.finish()
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/parallel/map_reduce.py", line 1239, in finish
        worker.join()
      File "/usr/local/Cellar/[email protected]/3.12.7/Frameworks/Python.framework/Versions/3.12/lib/python3.12/multiprocessing/process.py", line 148, in join
        assert self._popen is not None, 'can only join a started process'
               ^^^^^^^^^^^^^^^^^^^^^^^
    AssertionError: can only join a started process
**********************************************************************

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 5fc3606; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tornaria
Copy link
Contributor

Duplicate of #38873 ?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 31, 2024

A bit different solution for the same problem. I think the fix of this PR is more to the point.

Reviewer may choose a better one.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 31, 2024

Ah, it already got positive review. OK. I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants